IMPORTANT Localization

Thanks for your contribution!
I checked your fork but cannot see any commits by you there. Are you sure you have committed your changes? You need to fist commit the changes and push into your repo. Then make a Pull request to merge into the parent repo.
Thanks Martin. I’ll look at if later today and if you don’t mind, ask if I have any other questions.
 
No problem :)
Martin, just sent a pull request for a very small change to the pt translation just to ensure I don't screw anything up or loose too much time translating something I'm not able to submit just like last time. Let me know if it worked out when you have some time.

Thanks
 

Martin

HWiNFO Author
Staff member
Martin, just sent a pull request for a very small change to the pt translation just to ensure I don't screw anything up or loose too much time translating something I'm not able to submit just like last time. Let me know if it worked out when you have some time.

Thanks

Thanks, the pull request looks OK.
But one thing - is this only for Portuguese spoken in Brasil, so different from European Portuguese? Sorry, I'm not familiar how much Portuguese spoken in Brasil differs, but if it's significant, then this should probably be made as a new and different language tag and leave the original Portuguese as is?
 
Last edited:
Thanks, the pull request looks OK.
But one thing - is this only for Portuguese spoken in Brasil, so different from European Portuguese? Sorry, I'm not familiar how much Portuguese spoken in Brasil differs, but if it's significant, then this should probably be made as a new and different language tag and leave the original Portuguese as is?
Yes, there are significant differences between Brazilian and European Portuguese. I took this decision to change the description to Brazil instead of creating a new language tag because all the original translation in the file clearly is for Brazilian Portuguese, there’s nothing from European Portuguese in there, so I guessed it would make more sense to create a new tag for the European Portuguese if someone wants to translate. Does it make sense?

Example, file is arquivo in brazilian portugese and ficheiro in european portuguese.

Screen is tela at Brazil and ecrã in european portugese.

These are examples you can search the lang.txt file and check that the translations match the brazilian version I’m mentioning. I’m also attaching screenshots from hardware stores from Brazil and Portugal to give credibility of my examples.

I have to admit I was surprised that I just checked Google Translate and he offers just plain “Portuguese” for translation, but he tends to translate to the brazilian version.

I believe that someone from Portugal could understand the original translation in the file, I just wouldn’t call it ideal.

Please confirm if you want me to create a new language tag for my revision or if I should keep the way I changed.

Thanks
 

Attachments

  • 1FBDA426-F613-4F99-9531-ECA7FDFC73DD.jpeg
    1FBDA426-F613-4F99-9531-ECA7FDFC73DD.jpeg
    764.8 KB · Views: 6
  • 9B7EF0F3-DE5F-4948-BE1F-29873D4486C1.jpeg
    9B7EF0F3-DE5F-4948-BE1F-29873D4486C1.jpeg
    964.9 KB · Views: 6

Martin

HWiNFO Author
Staff member
Thank you for the exhausting explanation, I learned something new :)
I used the Google AI Translator (automated) to create the initial translations, that explains why the result is such.

Given this situation I have decided to proceed as following:
- I will merge your pull request as is.
- I will rename all current "pt" tags to "pt-BR" to properly reflect this set. So make sure to pull this change before you continue with other changes. This will also require a change in HWiNFO to properly handle Portuguese language which will be done in the next build.
- If anyone wants to contribute with other Portuguese variants, it should be added as a new tag (i.e. "pt-PT" for Portuguese in Portugal).
 

PiersJH

Well-Known Member
The file states to ask the author about adding a new language - can you please add en_GB (label it enGB if that's easier)?
 
Top